Skip to content
Snippets Groups Projects

TST: Make NamedTemporaryFiles Windows-compatible

Merged Henrik tom Wörden requested to merge f-rename-filter into dev

Summary

Die Pipelines laufen nicht, da die F-Branch Logik nicht funktioniert. Ich habe temporär für die meisten Unittests die richtige pylib version installiert:

https://gitlab.indiscale.com/caosdb/src/caosdb-crawler/-/jobs/358771

Daher kann davon ausgegangen werden, dass die Pipelines durchlaufen

Test Environment

pipeline

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #59688 failed

Pipeline failed for 3a230581 on f-rename-filter

Approval is optional

Merged by Alexander SchlemmerAlexander Schlemmer 2 months ago (Jan 13, 2025 1:12pm UTC)

Merge details

  • Changes merged into dev with 60203584.
  • Deleted the source branch.

Pipeline #59873 failed

Pipeline failed for 60203584 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading