Skip to content

F dir change date

Florian Spreckelsenrequested to merge
f-dir-change-date into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/umg/management/-/issues/234. Adds a match_newer_than_file option to the directory converter so that it only matches if its contents have been modified after a datetime given in a reference file.

Focus

Is the new behavior meaningful and as you would expect? In particular, can you imagine a use-case in which we wouldn't want to check the modification dates of the directory recursively but rather the parent directory's modification time?

Test Environment

The new unit test should be enough.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports