Skip to content
Snippets Groups Projects

F identifiable test

F identifiable test
f-identifiable-test into dev
1 unresolved thread
Merged Florian Spreckelsen requested to merge f-identifiable-test into dev
1 unresolved thread

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/60. Adds an integration test that tests whether a reference list of an existing record is updated correctly. It was meant as a test for the identifiable definitions in the real-world example but now also serves as a test for #12 (closed).

Focus

New integration test in test_real_world_example.py

Test Environment

Integration test should be sufficient. Remove the xfail to verify that the test fails as expected.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
    Florian Spreckelsen @florian started a thread on the diff
    • integrationtests/test_realworld_example.py
    94 93 ident.register_identifiable("Person", db.RecordType(
    95 94 ).add_parent("Person").add_property("full_name"))
    96 95
    97 crawler = Crawler(debug=True, identifiableAdapter=ident)
    96 crawler = Crawler(identifiableAdapter=ident)
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen requested review from @henrik

    requested review from @henrik

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Henrik tom Wörden mentioned in commit f0ebf631

    mentioned in commit f0ebf631

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply