Skip to content

FIX: Allow to set SSS debug logging verbosity

Florian Spreckelsen requested to merge f-reduce-sss-logfile-size into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/f-fit/management/-/issues/43. Introduces separate parameter to control sss debug log verbosity and decrease verbosity to errors only by default.

Focus

Is the new default reasonable. Do we want sss_max_log_level=logging.DEBUG (i.e., old behavior) to not have a breaking change?

Test Environment

  1. Run any SSS crawler with debug=False and verify that no DEBUG output is in the debuglog file.
  2. Re-run with debug=True to check that the debuglog has its old verbosity.
  3. Run with debug=False and sss_max_log_level=logging.DEBUG to verify that it restores the previous behavior.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading