System test for confirming issue #14 (parent updates)

Summary

This system test was written to confirm (or not reject) #14 (moved).

The scenario is as follows:

• Insert a file without a parent
• Create the result of a scan:
  • The same file was found, but a parent RT2 must be added.
  • A record needs to be created having the file as value of an obligatory property with type RT2.
• The crawler synchronizes LinkAhead with the above scan result.

If the bug was present, this would have resulted in an error. However, it does not. Please reject and close #14 (moved) if you can confirm this result.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

integrationtests/test_issues.py

@@ -28,6 +28,8 @@ from linkahead.cached import cache_clear
 from linkahead.utils.register_tests import clear_database, set_test_key
 from pytest import fixture, mark, raises
 
+import tempfile
+
 set_test_key("10b128cf8a1372f30aa3697466bb55e76974e0c16a599bb44ace88f19c8f61e2")
 
 
@@ -328,3 +330,46 @@ def test_indiscale_87(clear_database):
         print(db.apiutils.compare_entities(rec, retrieved))
         assert db.apiutils.empty_diff(rec, retrieved)
         print("---")
+
+
+def test_issue_14(clear_database):
+    """
+    Issue title: Some parent updates are required before inserts
+
+    https://gitlab.indiscale.com/caosdb/src/caosdb-crawler/-/issues/14
+    """
+
+    rt1 = db.RecordType(name="RT1")
+    rt2 = db.RecordType(name="RT2").insert()
+    rt1.add_property(rt2, importance=db.OBLIGATORY)
+    rt1.insert()
+
+    r = db.Record()
+    r.add_parent(rt1)
+    with tempfile.NamedTemporaryFile() as tmpf:
+        f = db.File(name="test_parent", path="parent_test/file.txt", file=tmpf.name)
+        f.insert()
+
+        # We create a clean new file object here:
+        f2 = db.File(name="test_parent", path="parent_test/file.txt", file=tmpf.name)
+
+    f2.add_parent(rt2)
+    r.add_property(name="RT2", value=f2)
+
+    # Current state in the database: File without parents
+    f_test_base = db.File(name="test_parent").retrieve()
+    assert len(f_test_base.parents) == 0
+    assert len(db.execute_query("FIND Record")) == 0
+
+    ident = CaosDBIdentifiableAdapter()
+    ident.register_identifiable("RT1", db.RecordType().add_parent(
+        name="RT1").add_property(name="RT2"))
+    crawler = Crawler(identifiableAdapter=ident)
+    crawler.synchronize(crawled_data=[f2, r])
+
+    f_test = db.File(name="test_parent").retrieve()
+    assert len(f_test.parents) == 1
+    assert f_test.parents[0].name == "RT2"
+    records = db.execute_query("FIND Record")
+    assert len(records) == 1
+    assert records[0].get_property("RT2").value == f_test.id