Skip to content

F update parents mitigation

Alexander Schlemmer requested to merge f-update-parents-mitigation into dev

Summary

This MR is a mitigation for #14 (moved) and updates changed parents before any other insertion / update transaction.

Focus

Note, that the (empty) dump was replaced by one with the new test_key.

Test Environment

See the failing tests in f-test-parent. Please remove the branch once you checked it out (It was merged in this one).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading