Skip to content
Snippets Groups Projects

F update parents mitigation

Merged F update parents mitigation
f-update-parents-mitigation into dev
2 unresolved threads
Merged Alexander Schlemmer requested to merge f-update-parents-mitigation into dev
2 unresolved threads

Summary

This MR is a mitigation for #14 (moved) and updates changed parents before any other insertion / update transaction.

Focus

Note, that the (empty) dump was replaced by one with the new test_key.

Test Environment

See the failing tests in f-test-parent. Please remove the branch once you checked it out (It was merged in this one).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #29073 passed with warnings

Stage: info
Stage: setup
Stage: cert
Stage: style
Stage: test

Pipeline passed with warnings for 09d34a86 on f-update-parents-mitigation

Merged by Alexander SchlemmerAlexander Schlemmer 2 years ago (Oct 7, 2022 1:59pm UTC)

Loading

Pipeline #29149 passed with warnings

Stage: info
Stage: setup
Stage: cert
Stage: style
Stage: test

Pipeline passed with warnings for db761bcb on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
integrationtests/test_data/extroot/use_case_simple_presentation/cfood.yml
22 22
23 23 records:
24 24 mdfile:
25 parents: []
25 parents:
26 - mdfile
  • Henrik tom Wörden
    Henrik tom Wörden @henrik started a thread on an old version of the diff
    • integrationtests/test_use_case_simple_presentation.py
    38 from caosdb.utils.register_tests import clear_database, set_test_key
    39 set_test_key("10b128cf8a1372f30aa3697466bb55e76974e0c16a599bb44ace88f19c8f61e2")
    41 40
    42 41 DATADIR = os.path.join(os.path.dirname(__file__), "test_data",
    43 42 "extroot", "use_case_simple_presentation")
    44 43
    45 44
    46 @pytest.fixture
    47 def clear_database():
    48 # TODO(fspreck): Remove once the corresponding advancedtools function can be
    49 # used.
    50 ents = db.execute_query("FIND ENTITY WITH ID>99")
    51 if ents:
    52 ents.delete()
    53
    54
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden removed review request for @henrik

    removed review request for @henrik

  • Henrik tom Wörden added 1 commit

    added 1 commit

    • 543e25bd - MAINT: disable set test key temporarily

    Compare with previous version

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Schlemmer marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Alexander Schlemmer marked the checklist item In-code documentation and comments are up-to-date. as incomplete

    marked the checklist item In-code documentation and comments are up-to-date. as incomplete

  • Alexander Schlemmer marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Alexander Schlemmer marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as incomplete

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as incomplete

  • Alexander Schlemmer mentioned in commit db761bcb

    mentioned in commit db761bcb

  • Alexander Schlemmer merged

    merged

    • Please register or sign in to reply