Skip to content

F unit

Florian Spreckelsen requested to merge f-unit into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/icbm/management/-/issues/47 (https://gitlab.com/linkahead/linkahead-crawler/-/issues/64). Implements units in crawler. Also changes a bit the behavior when property values are given as dicts in the cfood definition (value is parsed in the same way as a single string, collection_mode is not mandatory anymore).

Focus

The main changes are in the handle_value function that now determines the property value, the collection mode, and the property unit (which defaults to None, of course).

Test Environment

New unit tests (and the fact that despite the introduction of units, the old unit and integration tests still pass) should be sufficient. Feel free to test this crawler version with your favorite example though, to make sure that it didn't have any unwanted side effects.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports