Skip to content

F fix url formatting

Florian Spreckelsen requested to merge f-fix-url-formatting into dev

Summary

Part of https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/302. Use urllib.parse.join instead of string concatenation for link generation.

Focus

Nothing new, just use built-in functions to prevent missing or extra / and the like.

Test Environment

Run with Geomar server profile, set crawler in profile.yml to this branch, upload some samples and look into the sendmail_to_file output in /tmp/mail to verify that the URIs are generated correctly.

Also, new unit test.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports