MAINT: remove `retrieve_identified_record_for_record` and `resolve_reference`

Summary

This is no longer needed. #141 (closed)

Test Environment

Pipelines

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caoscrawler/identifiable_adapters.py

@@ -264,10 +264,6 @@ class IdentifiableAdapter(metaclass=ABCMeta):
         """
         pass
 
-    @abstractmethod
-    def resolve_reference(self, record: db.Record):
-        pass
-
     @abstractmethod
     def get_file(self, identifiable: db.File):
         warnings.warn(
@@ -409,28 +405,6 @@ class IdentifiableAdapter(metaclass=ABCMeta):
         """
         pass
 
-    def retrieve_identified_record_for_record(
-        self, record: db.Record, referencing_entities=None
-    ):
-        """
-        This function combines all functionality of the IdentifierAdapter by
-        returning the identifiable after having checked for an appropriate
-        registered identifiable.
-
-        In case there was no appropriate registered identifiable or no identifiable could
-        be found return value is None.
-        """
-        if record.path is not None:
-            return cached_get_entity_by(path=record.path)
-        if record.id is not None:
-            return cached_get_entity_by(eid=record.id)
-
-        identifiable = self.get_identifiable(
-            record, referencing_entities=referencing_entities
-        )
-
-        return self.retrieve_identified_record_for_identifiable(identifiable)
-
     @staticmethod
     def referencing_entity_has_appropriate_type(parents, register_identifiable):
         """returns true if one of the parents is listed by the 'is_referenced_by' property
@@ -585,26 +559,6 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter):
             return None
         return candidates[0]
 
-    def resolve_reference(self, value: db.Record):
-        if self.get_registered_identifiable(value) is None:
-            raise NotImplementedError(
-                "Non-identifiable references cannot"
-                " be used as properties in identifiables."
-            )
-            # TODO: just resolve the entity
-
-        value_identifiable = self.retrieve_identified_record_for_record(value)
-        if value_identifiable is None:
-            raise RuntimeError(
-                "The identifiable which is used as property"
-                " here has to be inserted first."
-            )
-
-        if value_identifiable.id is None:
-            raise RuntimeError("The entity has not been assigned an ID.")
-
-        return value_identifiable.id
-
 
 class CaosDBIdentifiableAdapter(IdentifiableAdapter):
     """
@@ -669,15 +623,6 @@ class CaosDBIdentifiableAdapter(IdentifiableAdapter):
             if definition.parents[0].name.lower() == rt_name.lower():
                 return definition
 
-    def resolve_reference(self, record: db.Record):
-        """
-        Current implementation just sets the id for this record
-        as a value. It needs to be verified that references all contain an ID.
-        """
-        if record.id is None:
-            return record
-        return record.id
-
     def retrieve_identified_record_for_identifiable(self, identifiable: Identifiable):
         query_string = self.create_query_for_identifiable(identifiable)
         try: