F dict heuristic
Compare changes
Files
68- Florian Spreckelsen authored
Part of https://gitlab.indiscale.com/caosdb/customers/3dmmto/management/-/issues/30. Introduce a converter that automatically transforms dictionary entries to property values without having to specify them explicitly. It also also creates referenced Records from object-typed dictionary values. Properties can be blacklisted.
The new converter extends the existing DictElementConverter
, so we can still use the existing treatment via records
and subtree
entries in the converter definition. This allows for the special treatment of blacklisted dictionary keys, but it is not limited to them. We do not change the original create_children
method, so all dictionary entries are also available in the subtree if needed elsewhere.
Mainly the new converter and its documentation.
make doc
and check the new documentation. Is it understandable? Is it useful?
For actual testing the new unit test should be sufficient. Can you think of corner cases that they do not cover yet?
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.