Unmodifiable Identifiables
Summary
Make attributes of the identifiable class unmodifiable properties.
Focus
Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?
Test Environment
How to set up a test environment for manual testing?
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @henrik
67 69 self.name = name 68 70 if name == "": 69 71 self.name = None 70 self.properties: dict = {} 72 self._properties: dict = {} 71 73 if properties is not None: 72 self.properties = properties 73 self.backrefs: list[Union[int, db.Entity]] = [] 74 self._properties = properties 75 self._backrefs: list[Union[int, db.Entity]] = [] 74 76 if backrefs is not None: 75 self.backrefs = backrefs 77 self._backrefs = backrefs 78 self._representation = sha256( 79 self._create_hashable_string(self).encode('utf-8')).hexdigest() changed this line in version 3 of the diff