Skip to content

MAINT: do not treat records if no Identifiable can be created

Henrik tom Wörden requested to merge f-constant-ident into f-refactor-merge

Summary

This has a new continue condition in the loop of split_into_inserts_and_updates. And related refactoring.

Focus

I introduced the function _identity_relies_on_unchecked_entities that checks whether an identifiable would contain any entity that is not yet verified (it was checked whether it exists on the remote server). If that is the case, we continue with the next Record and we do no longer create an identifiable that is unusable because it contains a Python object.

This implies that we can in future create the identifiable once for every record since id does not change!

Test Environment

pipeline

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues #123 (closed)
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading