Skip to content

F fix reference list

Florian Spreckelsen requested to merge f-fix-reference-list into dev

Summary

For #5 (closed). Fixes a bug (or two) that prevented list insertion.

Focus

Datatypes of properties are now forced to db.LIST if the value is a list instance.

Test Environment

Use zmt testdata, i.e.,

  1. start zmt server-profile in local-crawler-prototype branch
  2. install the crawler in this branch
  3. execute './crawl.sh' in ZMT's dataset-crawler repo

Verify that the newly created dataset Record has a list of events and authors (compare with metadata.json in server-profile/integration-test/data/35/03...)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • [ ] All automated tests pass
  • Reference related issues
  • [ ] Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading