Skip to content

ENH: add utility function that replaces name strings in values of reference properties with IDs

Henrik tom Wörden requested to merge f-resolve-named-refs into dev

Summary

In some cases, we want to set the value of a reference Property using the name of the referenced entity. Typically, this works like a charm and with no special stuff to be observed. However, if the name is not globally unique, but there is only one Record with the appropriate RecordType as parent,then we can uniquely identify the correct record, but the LinkAhead server does (currently) not on its own.

Focus

Only if meaningful, the properties must change...

Test Environment

Carefully check the unittest and possibly test it manually.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports