Skip to content
Snippets Groups Projects

F integration test simple

Merged Alexander Schlemmer requested to merge f-integration-test-simple into dev

Summary

An integration test for a simple use case of the crawler. It was used during a live presentation of caosdb and the new crawler.

Focus

Have a look at the assertions in the test file, please. Is there anything missing?

Test Environment

  • A: Start an empty docker container and run pytest use_case_simple_presentation.py. This will interactively register the currently running docker container with this test.
  • B: Use a previously registered docker container and run pytest use_case_simple_presentation.py.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply