Skip to content

FIX: Better implementation of split_restricted_path that fixes an error. Also...

Florian Spreckelsen requested to merge f-test-duplicate-names-no-identifiable into dev

Summary

Test to confirm https://gitlab.com/linkahead/linkahead-crawler/-/issues/83 or to ensure that https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/192 is not caused by a crawler bug.

Focus

The new test should make sure that in case of name not in the identifiable, two records can have the same names but different identifying properties are identified correctly as two different entities, also in referencing records.

Test Environment

If pipeline is up and running, no manual testing is needed.

For manual testing, start linkahead with integrationtests/test-profile/profile.yml and execute

pytest -vvv integrationtests/test_issues.py::test_issue_83

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports