Skip to content

f-special-chars-in-names

Florian Spreckelsen requested to merge f-special-chars-in-names into dev

Summary

This was necessary for https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/212. It fixes an issue whereby the identifiable query would be broken in case of spaces or special characters in RecordType or Identifiable names.

Not that this is only a temporary hotfix as needed until caosdb-pylib#165 has been implemented.

Focus

Few changes in the IdentifiableAdapter class.

Test Environment

Unit test

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports