Use cached_get_entity_by

Summary

Replace Crawler._get_entity_by... by cached versions of pylib.

Please track on https://gitlab.indiscale.com/caosdb/customers/umg/management/-/issues/84

Test Environment

unit and int tests

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary) no api change; internal refactoring
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

unittests/test_tool.py

@@ -589,8 +589,8 @@ def test_replace_entities_with_ids(crawler):
 
 
 def mock_get_entity_by(eid=None, name=None):
-    if id is not None:
-        candidates = [el for el in list(full_data.values()) if el.id == id]
+    if eid is not None:
+        candidates = [el for el in list(full_data.values()) if el.id == eid]
         if len(candidates) > 0:
             return candidates[0]
         else: