Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?
I suggest local-testing setup of dpz.
package: "git+https://gitlab.indiscale.com/caosdb/src/caosdb-pylib.git@f-validate-caoscrawler"
package: "git+https://gitlab.indiscale.com/caosdb/src/caosdb-crawler.git@f-email-notify"
crawler_run_model.yml
python runcrawler.py
/tmp/mail/somemail
CrawlerRun
Record in LinkAheadPlease, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.