Refactoring of the crawler and scanner:
The main steps in refactoring were:
Left TODO:
The best procedure for the review probably is to go through the individual commits. I tried to keep them as fine-grained as possible. Fixing the tests actually was very repetitive, because the API was changed slightly.
There is one thing that might be solved not completely ideal:
Unittests
I did not run the integration tests manually, but this is probably done by the pipeline.
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.