MAINT: Operate in-place in _recursively_create_records

src/caoscrawler/converters.py

@@ -886,7 +886,7 @@ class PropertiesFromDictConverter(DictElementConverter):
                             ref_rec.add_parent(key)
                         records[ref_var_name] = ref_rec
                         values[ref_var_name] = ref_rec
-                        keys_modified, ref_rec = self._recursively_create_records(
+                        keys_modified = self._recursively_create_records(
                             subdict=ref_dict,
                             root_record=ref_rec,
                             root_rec_name=ref_var_name,
@@ -908,7 +908,7 @@ class PropertiesFromDictConverter(DictElementConverter):
                     ref_rec.add_parent(key)
                 records[ref_var_name] = ref_rec
                 values[ref_var_name] = ref_rec
-                keys_modified, ref_rec = self._recursively_create_records(
+                keys_modified = self._recursively_create_records(
                     subdict=value,
                     root_record=ref_rec,
                     root_rec_name=ref_var_name,
@@ -928,7 +928,7 @@ class PropertiesFromDictConverter(DictElementConverter):
         if referenced_record_callback:
             root_record = referenced_record_callback(root_record)
 
-        return keys_modified, root_record
+        return keys_modified
 
     def create_records(self, values: GeneralStore, records: RecordStore,
                        element: StructureElement):
@@ -951,7 +951,7 @@ class PropertiesFromDictConverter(DictElementConverter):
         else:
             rec = records[rfd["variable_name"]]
 
-        keys_modified, rec = self._recursively_create_records(
+        keys_modified = self._recursively_create_records(
             subdict=element.value,
             root_record=rec,
             root_rec_name=rfd["variable_name"],