up

unittests/test_tool.py

@@ -512,8 +512,6 @@ def test_all_references_are_existing_already2(crawler):
     crawler.identifiableAdapter.get_registered_identifiable = Mock(side_effect=partial(
         basic_ident_lookup, idents=registered_identifiables))
 
-    # no reference to check
-    assert crawler.all_references_are_existing_already(db.Record().add_parent("C"))
     # one reference with id
     assert crawler.all_references_are_existing_already(
         db.Record().add_parent("C").add_property('a', 123))
@@ -540,24 +538,27 @@ def test_all_references_are_existing_already(crawler):
     # Simulate remote server content by using the names to identify records
     # There are only two known Records with name A and B
     crawler.identifiableAdapter.get_registered_identifiable = Mock(side_effect=partial(
-        basic_retrieve_by_name_mock_up, known={"A": db.Record(name="A").add_parent("C"),
-                                               "B": db.Record(name="B").add_parent("C")}))
+        basic_retrieve_by_name_mock_up, known={"C": db.Record(name="C").add_parent("C")
+                                               .add_property("d"),
+                                               "D": db.Record(name="D").add_parent("D")
+                                               .add_property("d").add_property("e"),
+                                               }))
 
     assert crawler.all_references_are_existing_already(
-        db.Record().add_property('a', 123))
-    assert crawler.all_references_are_existing_already(db.Record()
-                                                       .add_property('a', db.Record(id=123)))
-    assert crawler.all_references_are_existing_already(db.Record().add_parent("D")
-                                                       .add_property('a', 123)
+        db.Record(name="C").add_parent("C").add_property('d', 123))
+    assert crawler.all_references_are_existing_already(db.Record(name="C")
+                                                       .add_property('d', db.Record(id=123)))
+    assert crawler.all_references_are_existing_already(db.Record(name="C").add_parent("D")
+                                                       .add_property('d', 123)
                                                        .add_property('b', db.Record(id=123)))
-    a = db.Record(name="A").add_parent("C").add_property("a", 12311)
-    assert not crawler.all_references_are_existing_already(db.Record().add_parent("D")
-                                                           .add_property('a', 123)
-                                                           .add_property('b', a))
+    a = db.Record(name="C").add_parent("C").add_property("d", 12311)
+    assert not crawler.all_references_are_existing_already(db.Record(name="D").add_parent("D")
+                                                           .add_property('d', 123)
+                                                           .add_property('e', a))
     crawler.add_identified_record_to_local_cache(a)
-    assert crawler.all_references_are_existing_already(db.Record().add_parent("D")
-                                                       .add_property('a', 123)
-                                                       .add_property('b', a))
+    assert crawler.all_references_are_existing_already(db.Record(name="D").add_parent("D")
+                                                       .add_property('d', 123)
+                                                       .add_property('e', a))
     # if this ever fails, the mock up may be removed
     crawler.identifiableAdapter.get_registered_identifiable.assert_called()
 
@@ -580,18 +581,19 @@ def test_can_be_checked_externally2(crawler):
                                                  .add_property('b', db.Record()))
 
 
-def test_can_be_checked_externally(crawler):
+def test_can_be_checked_externally(crawler, ident):
     assert crawler.can_be_checked_externally(
-        db.Record().add_property('a', 123))
-    assert crawler.can_be_checked_externally(db.Record()
-                                             .add_property('a', db.Record(id=123)))
-    assert crawler.can_be_checked_externally(db.Record().add_parent("D")
-                                             .add_property('a', 123)
-                                             .add_property('b', db.Record(id=123)))
-
-    assert not crawler.can_be_checked_externally(db.Record().add_parent("D")
-                                                 .add_property('a', 123)
-                                                 .add_property('b', db.Record()))
+        db.Record().add_parent("Person").add_property('last_name', 123).add_property('first_name', 123))
+    assert crawler.can_be_checked_externally(db.Record().add_parent("Person")
+                                             .add_property('first_name', 123)
+                                             .add_property('last_name', db.Record(id=123)))
+    assert crawler.can_be_checked_externally(db.Record().add_parent("Person")
+                                             .add_property('first_name', 123)
+                                             .add_property('last_name', db.Record(id=123)))
+
+    assert not crawler.can_be_checked_externally(db.Record().add_parent("Person")
+                                                 .add_property('first_name', 123)
+                                                 .add_property('last_name', db.Record()))
 
 
 def test_replace_entities_with_ids(crawler):