Skip to content
Snippets Groups Projects

F update

All threads resolved!
Merged Timm Fitschen requested to merge f-update into dev
All threads resolved!

Summary

Implements update for a single entity

See https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/392

Focus

  • Updating entities works like this: Retrieve an entity, copy it and put it in the update transaction.
  • ResultSet has an iterator now
  • I privatated SetId and SetVersionId (nobody should ever need to change it, because Entities which are to be updated have to be retrieved first anyway.)
  • More fine-grained TransactionStatus (INITIAL -> GO_ON -> READY -> EXECUTE -> SUCCESS/ERROR) and corresponding StatusCodes

Test Environment

Use with server branch f-grpc-f-update

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen added 2 commits

    added 2 commits

    • 05021806 - 1 commit from branch dev
    • d42276ca - Merge branch 'dev' into f-update

    Compare with previous version

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen
  • added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen added 1 commit

    added 1 commit

    • c2ed898c - REVIEW: apply suggested changes

    Compare with previous version

  • Timm Fitschen marked this merge request as ready

    marked this merge request as ready

  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen added 2 commits

    added 2 commits

    • 2dbea4df - 1 commit from branch dev
    • 0d3ce44a - Merge branch 'dev' into f-update

    Compare with previous version

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • Timm Fitschen mentioned in commit af35fe5b

    mentioned in commit af35fe5b

  • merged

  • Please register or sign in to reply
    Loading