F better errors

Summary

Minor improvements to error messages in test clients and conanfile.

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/cxxlinkaheadcli.cpp

@@ -43,20 +43,27 @@ const auto logger_name = "liblinkahead";
 
 auto main() -> int {
 
-  std::cout << "LinkAhead C++ client (liblinkahead " << linkahead::LIBLINKAHEAD_VERSION_MINOR << "."
+  std::cout << "LinkAhead C++ client (liblinkahead " << linkahead::LIBLINKAHEAD_VERSION_MAJOR << "."
             << linkahead::LIBLINKAHEAD_VERSION_MINOR << "." << linkahead::LIBLINKAHEAD_VERSION_PATCH
-            << ")\n"
-            << std::endl;
+            << ")\n";
 
   try {
     const auto &connection = linkahead::connection::ConnectionManager::GetDefaultConnection();
 
-    connection->RetrieveVersionInfoNoExceptions();
+    auto status = connection->RetrieveVersionInfoNoExceptions();
+    if (status.GetCode() == linkahead::CONNECTION_ERROR) {
+      const auto connection_config =
+        linkahead::configuration::ConfigurationManager::GetDefaultConnectionConfiguration();
+      std::cout << "ConnectionError: Cannot connect to " << connection_config->GetHost() << ":"
+                << connection_config->GetPort() << '\n';
+
+      return 1;
+    }
     // get version info of the server
     const auto &v_info = connection->GetVersionInfo();
     std::cout << "Server Version: " << v_info->GetMajor() << "." << v_info->GetMinor() << "."
               << v_info->GetPatch() << "-" << v_info->GetPreRelease() << "-" << v_info->GetBuild()
-              << std::endl;
+              << '\n';
 
     // retrieve an entity
     auto transaction(connection->CreateTransaction());
@@ -67,12 +74,12 @@ auto main() -> int {
       << "status: " << t_stat.GetCode() << " // " << t_stat.GetDescription();
     const auto &result_set = transaction->GetResultSet();
     for (const auto &entity : result_set) {
-      std::cout << entity.ToString() << std::endl;
+      std::cout << entity.ToString() << '\n';
     }
 
     // execute a query
     std::string query("FIND Property \"Prop *\"");
-    std::cout << "Trying to execute a query:\n" << query << std::endl;
+    std::cout << "Trying to execute a query:\n" << query << '\n';
     auto q_transaction(connection->CreateTransaction());
     q_transaction->Query(query);
     q_transaction->ExecuteAsynchronously();
@@ -81,18 +88,18 @@ auto main() -> int {
       << "status: " << t_stat.GetCode() << " // " << t_stat.GetDescription();
     const auto &result_set_2 = q_transaction->GetResultSet();
     for (const auto &entity : result_set_2) {
-      std::cout << entity.ToString() << std::endl;
+      std::cout << entity.ToString() << '\n';
     }
 
     return 0;
   } catch (const linkahead::exceptions::ConfigurationError &exc) {
-    std::cout << "ConfigurationError: " << exc.what() << std::endl;
+    std::cout << "ConfigurationError: " << exc.what() << '\n';
     return exc.GetCode();
   } catch (const std::exception &exc) {
-    std::cout << "Exception: " << exc.what() << std::endl;
+    std::cout << "Exception: " << exc.what() << '\n';
     return 1;
   } catch (...) {
-    std::cout << "Some other exception." << std::endl;
+    std::cout << "Some other exception." << '\n';
     return 2;
   }
 }