Fix conan create on Windows
Summary
Fixes:
Creating the conan package and installing on Windows had some issues. This MR fixes that.
Focus
-
conan create
now works on Windows without errors (e.g. via.\make.ps1 conan-create
) -
cmake --install
results in output files being installed to%appdata%\LinkAhead
, e.g.C:\Users\Joscha\AppData\Roaming\LinkAhead
Test Environment
Regular
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary)How do I use the software? Assume "stupid" users.-
How do I develop or debug the software? Assume novice developers.~
-
Annotations in code (Gitlab comments)- Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen