Resolve "Windows: Linker errors with protobuf-generated code"
Compare changes
- Joscha Schmiedt authored
make.ps1
0 → 100644
+ 65
− 0
Related to #90 (closed)
caosdb_grpc
CMAKE_BINARY_DIR
)make.ps1
) for easily building on Windows.Building libraries, cli clients and tests now completes without errors.
Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?
Follow build instructions in the updated Install_develop.rst. Basically,
.\make.ps1 all
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.