Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
caosdb-cpplib
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
caosdb
Software
caosdb-cpplib
Merge requests
!42
Release 0.2.0
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Closed
Release 0.2.0
release-0.2.0
into
main
Overview
0
Commits
87
Pipelines
1
Changes
1
Closed
Timm Fitschen
requested to merge
release-0.2.0
into
main
2 years ago
Overview
0
Commits
87
Pipelines
1
Changes
1
0
0
Merge request reports
Viewing commit
e4fc823b
Prev
Next
Show latest version
1 file
+
4
−
0
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Verified
e4fc823b
Add TODO for SegFault Factory in GetResultSet
· e4fc823b
Timm Fitschen
authored
3 years ago
include/caosdb/transaction.h
+
4
−
0
View file @ e4fc823b
Show full file
@@ -408,6 +408,10 @@ public:
CAOSDB_LOG_ERROR
(
logger_name
)
<<
"GetResultSet was called before the transaction has terminated. This is a programming "
"error of the code which uses the transaction."
;
// TODO(tf) This is a really bad SegFault factory. When the transaction
// terminates and the result_set is being overriden, the unique_ptr
// created here will be deleted and any client of the return ResultSet
// will have a SegFault.
}
else
if
(
this
->
GetStatus
().
GetCode
()
==
StatusCode
::
SPOILED
)
{
CAOSDB_LOG_ERROR
(
logger_name
)
<<
"GetResultSet was called on a
\"
spoiled
\"
transaction. That means "
Loading