F dot in username
-
Review changes -
-
Download -
Patches
-
Plain diff
Summary
Adds a very simple User
class and methods for creation, retrieval and deletion. This allows us to test the user creation/deletion of the GRPC API.
The User
class and the methods are only available when the newly introduced "BUILD_ACM" macro is set. The make files and the pipeline has been updated for this.
Focus
The User
class is designed after the delegator/wrapper pattern where UserImpl
is the delegate. The UserImpl
class is a wrapper for protobuf's User
message objects. This might look clumsy at first but it has the advantage that the grpc/protobuf code is encapsuled and hidden in the *.cpp file. This is a first test which demonstrates how we can remove the grpc/protobuf dependency from the headers altogether (which will make it easier to compile the library as a shared library on windows).
Test Environment
- See unit test in test_user
- See integration tests in caosdb-cppinttest!23 (merged)
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
- version 1830a9005f
- version 171816f06d
- version 1671fc5b24
- version 15fd0769be
- version 1478f84606
- version 13714d02d2
- version 1223b34547
- version 11ee041b42
- version 108d09f71f
- version 9a5b7293b
- version 83e3196e5
- version 786a57546
- version 6184cbbf6
- version 553f53831
- version 4b0047f3e
- version 3b4742f31
- version 26455ea8f
- version 1f611e307
- dev (base)
- latest version30a9005f26 commits,
- version 1830a9005f26 commits,
- version 171816f06d25 commits,
- version 1671fc5b2424 commits,
- version 15fd0769be23 commits,
- version 1478f8460622 commits,
- version 13714d02d221 commits,
- version 1223b3454720 commits,
- version 11ee041b4219 commits,
- version 108d09f71f18 commits,
- version 9a5b7293b17 commits,
- version 83e3196e516 commits,
- version 786a5754614 commits,
- version 6184cbbf613 commits,
- version 553f5383112 commits,
- version 4b0047f3e11 commits,
- version 3b4742f3110 commits,
- version 26455ea8f9 commits,
- version 1f611e3078 commits,
- Side-by-side
- Inline