F dot in username

Summary

Adds a very simple User class and methods for creation, retrieval and deletion. This allows us to test the user creation/deletion of the GRPC API.

The User class and the methods are only available when the newly introduced "BUILD_ACM" macro is set. The make files and the pipeline has been updated for this.

Focus

The User class is designed after the delegator/wrapper pattern where UserImpl is the delegate. The UserImpl class is a wrapper for protobuf's User message objects. This might look clumsy at first but it has the advantage that the grpc/protobuf code is encapsuled and hidden in the *.cpp file. This is a first test which demonstrates how we can remove the grpc/protobuf dependency from the headers altogether (which will make it easier to compile the library as a shared library on windows).

Test Environment

• See unit test in test_user
• See integration tests in caosdb-cppinttest!23 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/cxxcaosdbcli.cpp

@@ -46,7 +46,9 @@ using boost::program_options::positional_options_description;
 using boost::program_options::store;
 using boost::program_options::value;
 using boost::program_options::variables_map;
+#ifdef BUILD_ACM
 using caosdb::acm::Role;
+#endif
 
 auto print_version(bool print) -> void {
   if (print) {
@@ -98,6 +100,7 @@ auto execute_query(std::string query) -> void {
   }
 }
 
+#ifdef BUILD_ACM
 auto list_roles() -> void {
   std::cout << "Known roles:" << std::endl;
   const auto &connection = caosdb::connection::ConnectionManager::GetDefaultConnection();
@@ -125,6 +128,7 @@ auto delete_role(std::string name) {
   connection->DeleteSingleRole(name);
   std::cout << "OK" << std::endl;
 }
+#endif
 
 auto main(int argc, const char *argv[]) -> int {
   try {
@@ -137,10 +141,14 @@ auto main(int argc, const char *argv[]) -> int {
       "retrieve", value<std::string>()->notifier(retrieve_entity_by_id),
       "Retrieve an entity by id and print its JSON representation.")(
       "execute-query", value<std::string>()->notifier(execute_query),
-      "Execute a query and print the results")("list-roles", "List all known roles")(
-      "retrieve-role", value<std::string>()->notifier(retrieve_role), "Retrieve a role by name")(
-      "create-role", value<std::string>()->notifier(create_role), "Create a new role")(
-      "delete-role", value<std::string>()->notifier(delete_role), "Create a new role");
+      "Execute a query and print the results")
+#ifdef BUILD_ACM
+      ("list-roles", "List all known roles")(
+        "retrieve-role", value<std::string>()->notifier(retrieve_role), "Retrieve a role by name")(
+        "create-role", value<std::string>()->notifier(create_role), "Create a new role")(
+        "delete-role", value<std::string>()->notifier(delete_role), "Create a new role")
+#endif
+      ;
 
     parser.options(desc);
 
@@ -158,6 +166,7 @@ auto main(int argc, const char *argv[]) -> int {
     } else if (vm["version"].as<bool>()) {
     } else if (vm.count("test-connection")) {
       test_connection();
+#ifdef BUILD_ACM
     } else if (vm.count("list-roles")) {
       list_roles();
     } else if (vm.count("retrieve-role")) {
@@ -165,6 +174,7 @@ auto main(int argc, const char *argv[]) -> int {
     } else if (vm.count("create-role")) {
     } else if (vm.count("delete-role")) {
     } else if (vm.count("execute-query")) {
+#endif
     } else {
       print_version(true);
       test_connection();