Skip to content
Snippets Groups Projects

ENH: Allow insertion and deletion of single entities

Merged ENH: Allow insertion and deletion of single entities
f-insert into dev
All threads resolved!
Merged Florian Spreckelsen requested to merge f-insert into dev
All threads resolved!

Summary

See https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/394. Implementations for entities, parents, and properties were added. The transactions were extended s.th. all objects can be inserted, retrieved, and deleted.

Focus

Most of the new stuff is in entity.cpp and entity.h. See test_entity for the new functionality.

Test Environment

Unit and integration tests should be sufficient.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • [ ] Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • [ ] Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #11291 passed

Stage: info
Stage: setup
Stage: test
Stage: deploy
Pipeline: caosdb-cppinttest

#11293

    Pipeline passed for 19a251ea on f-insert

    Approval is optional
    Loading
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen marked this merge request as ready

    marked this merge request as ready

  • Florian Spreckelsen requested review from @timm

    requested review from @timm

  • Timm Fitschen added 1 commit

    added 1 commit

    • f50b9221 - REVIEW: minor changes in the build, add IWYU pragmas

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen resolved all threads

    resolved all threads

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 7c0baafc - REVIEW: ignore clang's cognitive-complexity for tests

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 1425fc8e - REVERT: changes in CHANGELOG

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Timm Fitschen enabled an automatic merge when the pipeline for 19a251ea succeeds

    enabled an automatic merge when the pipeline for 19a251ea succeeds

  • Timm Fitschen canceled the automatic merge

    canceled the automatic merge

  • Timm Fitschen canceled the automatic merge

    canceled the automatic merge

  • Timm Fitschen merged

    merged

    • Please register or sign in to reply