Skip to content
Snippets Groups Projects

Use "trigger" keyword for pipeline.

Merged Daniel Hornung requested to merge f-trigger into dev
All threads resolved!

Summary

Use "trigger" keyword for pipeline. See #44 (closed)

Focus

Are the variables set correctly?

Test Environment

Look at pipelines and see if they work.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Pipeline #25274 passed

Pipeline: caosdb-cppinttest

#25275

    Pipeline passed for e6cf68ec on f-trigger

    Approved by

    Merged by Timm FitschenTimm Fitschen 2 years ago (Jul 7, 2022 3:13pm UTC)

    Merge details

    • Changes merged into dev with 3e34abaa.
    • Deleted the source branch.

    Pipeline #25437 passed

    Pipeline: caosdb-cppinttest

    #25444

      Pipeline passed for 3e34abaa on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • Daniel Hornung requested review from @timm

      requested review from @timm

    • Daniel Hornung removed review request for @henrik

      removed review request for @henrik

    • Timm Fitschen resolved all threads

      resolved all threads

    • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

      marked the checklist item I understand the intent of this MR as completed

    • Timm Fitschen marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

      marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

      marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

      marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

      marked the checklist item In-code documentation and comments are up-to-date. as completed

    • Timm Fitschen approved this merge request

      approved this merge request

    • Timm Fitschen mentioned in commit 3e34abaa

      mentioned in commit 3e34abaa

    • merged

    • Please register or sign in to reply
      Loading