Use "trigger" keyword for pipeline.
All threads resolved!
All threads resolved!
Summary
Use "trigger" keyword for pipeline. See #44 (closed)
Focus
Are the variables set correctly?
Test Environment
Look at pipelines and see if they work.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (ornot necessary -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Timm Fitschen
Merge request reports
Activity
assigned to @daniel
requested review from @henrik
enabled an automatic merge when the pipeline for 679b5365 succeeds
added 46 commits
-
679b5365...c634d5df - 45 commits from branch
dev
- e6cf68ec - Merge branch 'dev' into f-trigger
-
679b5365...c634d5df - 45 commits from branch
- Resolved by Timm Fitschen
requested review from @timm
removed review request for @henrik
mentioned in commit 3e34abaa
Please register or sign in to reply