Skip to content
Snippets Groups Projects

FIX: Explicit bfs:path conversion to string.

Merged Daniel Hornung requested to merge f-fix-25 into dev
All threads resolved!

Summary

Fixed the compiler and also a different linker issue.

Test Environment

Simply try to compile on a Mac with make conan.

Check List for the Author

  • All automated tests pass
  • Reference related Issues: #25 (closed)
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 8116b29c - DOC: More about version mismatches.

    Compare with previous version

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Seems not to work on MacOS 10.14 Catalina, since conan's abseil wouldn't compile. I suggest we only support Big Sur for now.

  • mentioned in commit 2ce0e458

  • Please register or sign in to reply
    Loading