Skip to content

F async execute

Timm Fitschen requested to merge f-async-execute into dev

Summary

  1. Makes ExecuteAsynchronously actually asynchronous.
  2. Version bump of grpc to 1.45.2

Focus

Most of the old execution code has been removed from ExecuteAsynchronously and WaitForIt and has been split up into DoExecuteTransaction(), ProcessCall, ProcessTerminated, and ProcessRetrieveResponse.

ExecuteAsynchronously now only start a background thread running DoExecuteTransaction and WaitForIt joins the background thread until it terminates.

Because we deal with multiple thread now, this MR also needed to introduce a mutex/lock system. We have a special non-public macro for this (TRANSACTION_SYNCRONIZED_BLOCK).

Test Environment

Pipelines should be enough. If we encounter problems in the dependent clients (julia, octave) afterwards we will see what we need to do then.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports