F move entity
Summary
Introduction/Refactoring of move/copy constructors and assignment operators for several classes.
Focus
- Always mind the Rule of 5
- New move and copy constructors and assignment operators for
DataType
. - New
==
and!=
operators forProtoMessageWrapper
andEntity
(needed for testing). - Simplified move constructor, copy/move assignment operators of
Property
. - New move constructor, copy/move assignment operators for
Entity
. - The new test cover all four things (move/copy constructors/assigment operators) for
Entity
,Property
, andParent
.
Test Environment
Pipeline testing should be sufficient
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @timm
added 4 commits
-
d535de96...bb42875c - 3 commits from branch
f-mixed-write-transactions
- facb19fd - Merge branch 'f-mixed-write-transactions' into f-move-entity
-
d535de96...bb42875c - 3 commits from branch
added 13 commits
-
facb19fd...7762d087 - 11 commits from branch
dev
- b7cefe64 - Merge branch 'dev' into f-move-entity
- 5ccac6d9 - WIP: move entity
-
facb19fd...7762d087 - 11 commits from branch
marked this merge request as draft from 5ccac6d9
added 5 commits
-
5ccac6d9...8ef5aeb0 - 4 commits from branch
dev
- 69c2497d - Merge branch 'dev' into f-move-entity
-
5ccac6d9...8ef5aeb0 - 4 commits from branch
added 2 commits
mentioned in issue #28 (closed)
requested review from @florian
added 9 commits
-
8dbcd0c3...f7b3e266 - 8 commits from branch
dev
- d7dea004 - Merge branch 'dev' into f-move-entity
-
8dbcd0c3...f7b3e266 - 8 commits from branch
enabled an automatic merge when the pipeline for d7dea004 succeeds
mentioned in commit 453dfcc9