Return to int64 for integer values

Summary

Returns to int64 as transport representation (and client representation) for integer values.

Server implemenation in caosdb-server!29 (merged)

Focus

• Most of the changes are "just" replacing the int32_t with int64_t.
• Also, a typo in ccaosdb.cpp which is unrelated has been fixed and tested.

Test Environment

• No manual testing needed.
• Integration tests are in caosdb-cppinttest!14 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• [ ] Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• [ ] Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

test/test_ccaosdb.cpp

@@ -24,6 +24,7 @@
 #include "caosdb/status_code.h"    // for StatusCode
 #include "caosdb_test_utility.h"   // for EXPECT_THROW_MESSAGE, TEST_DATA_DIR
 #include "ccaosdb.h"               // for caosdb_utility_get_env_fallback
+#include <cstdint>                 // for int64_t
 #include <cstring>                 // for strcmp
 #include <gtest/gtest-message.h>   // for Message
 #include <gtest/gtest-test-part.h> // for SuiteApiResolver, TestFactoryImpl
@@ -263,7 +264,7 @@ TEST_F(test_ccaosdb, test_property) {
   EXPECT_EQ(return_code, 0);
 }
 
-TEST_F(test_ccaosdb, test_list_property) {
+TEST_F(test_ccaosdb, test_string_list_property) {
 
   caosdb_entity_property property;
   int return_code(caosdb_entity_create_property(&property));
@@ -285,12 +286,12 @@ TEST_F(test_ccaosdb, test_list_property) {
   EXPECT_FALSE(*is_ref);
   EXPECT_TRUE(*is_list);
 
-  int length[] = {0}; // NOLINT
-  return_code = caosdb_entity_property_get_value_list_length(&property, length);
+  int length = -1; // NOLINT
+  return_code = caosdb_entity_property_get_value_list_length(&property, &length);
   EXPECT_EQ(return_code, 0);
-  EXPECT_EQ(*length, 3);
+  EXPECT_EQ(length, 3);
 
-  for (int i = 0; i < *length; i++) {
+  for (int i = 0; i < length; i++) {
     return_code = caosdb_entity_property_get_string_list_value_at(&property, &out, i);
     EXPECT_EQ(return_code, 0);
     EXPECT_EQ(strcmp(value_list[i], out), 0); // NOLINT
@@ -300,6 +301,82 @@ TEST_F(test_ccaosdb, test_list_property) {
   EXPECT_EQ(return_code, 0);
 }
 
+TEST_F(test_ccaosdb, test_int_list_property) {
+
+  caosdb_entity_property property;
+  int return_code(caosdb_entity_create_property(&property));
+  EXPECT_EQ(return_code, 0);
+
+  return_code = caosdb_entity_property_set_datatype(&property, "INTEGER", false, true);
+  EXPECT_EQ(return_code, 0);
+
+  const int64_t value_list[] = {1, 2, 3}; // NOLINT
+  return_code = caosdb_entity_property_set_int_list_value(&property, &(value_list)[0], 3);
+  EXPECT_EQ(return_code, 0);
+
+  char *dt_out = nullptr;   // NOLINT
+  bool is_ref[] = {false};  // NOLINT
+  bool is_list[] = {false}; // NOLINT
+  return_code = caosdb_entity_property_get_datatype(&property, &dt_out, is_ref, is_list);
+  EXPECT_EQ(return_code, 0);
+  EXPECT_STREQ(dt_out, "INTEGER");
+  EXPECT_FALSE(*is_ref);
+  EXPECT_TRUE(*is_list);
+
+  int length = -1; // NOLINT
+  return_code = caosdb_entity_property_get_value_list_length(&property, &length);
+  EXPECT_EQ(return_code, 0);
+  EXPECT_EQ(length, 3);
+
+  for (int i = 0; i < length; i++) {
+    int64_t out = -1;
+    return_code = caosdb_entity_property_get_int_list_value_at(&property, &out, i);
+    EXPECT_EQ(return_code, 0);
+    EXPECT_EQ(value_list[i], out); // NOLINT
+  }
+
+  return_code = caosdb_entity_delete_property(&property);
+  EXPECT_EQ(return_code, 0);
+}
+
+TEST_F(test_ccaosdb, test_bool_list_property) {
+
+  caosdb_entity_property property;
+  int return_code(caosdb_entity_create_property(&property));
+  EXPECT_EQ(return_code, 0);
+
+  return_code = caosdb_entity_property_set_datatype(&property, "BOOLEAN", false, true);
+  EXPECT_EQ(return_code, 0);
+
+  const bool value_list[] = {true, true, false}; // NOLINT
+  return_code = caosdb_entity_property_set_boolean_list_value(&property, &(value_list)[0], 3);
+  EXPECT_EQ(return_code, 0);
+
+  char *dt_out = nullptr;   // NOLINT
+  bool is_ref[] = {false};  // NOLINT
+  bool is_list[] = {false}; // NOLINT
+  return_code = caosdb_entity_property_get_datatype(&property, &dt_out, is_ref, is_list);
+  EXPECT_EQ(return_code, 0);
+  EXPECT_STREQ(dt_out, "BOOLEAN");
+  EXPECT_FALSE(*is_ref);
+  EXPECT_TRUE(*is_list);
+
+  int length = -1; // NOLINT
+  return_code = caosdb_entity_property_get_value_list_length(&property, &length);
+  EXPECT_EQ(return_code, 0);
+  EXPECT_EQ(length, 3);
+
+  for (int i = 0; i < length; i++) {
+    bool out = true;
+    return_code = caosdb_entity_property_get_boolean_list_value_at(&property, &out, i);
+    EXPECT_EQ(return_code, 0);
+    EXPECT_EQ(value_list[i], out); // NOLINT
+  }
+
+  return_code = caosdb_entity_delete_property(&property);
+  EXPECT_EQ(return_code, 0);
+}
+
 TEST_F(test_ccaosdb, test_entity_with_parent_and_property) {
   caosdb_entity_parent input_parent;
   int return_code(caosdb_entity_create_parent(&input_parent));