Skip to content
Snippets Groups Projects

Switch integer values to int32

Merged Daniel Hornung requested to merge f-int32 into dev

Summary

Insert a meaningful description for this merge request here.  What is the
new/changed behavior? Which bug has been fixed? Are there related Issues?

Focus

Point the reviewer to the core of the code change. Where should they start
reading? What should they focus on (e.g. security, performance,
maintainability, user-friendliness, compliance with the specs, finding more
corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports

Pipeline #12636 passed

Pipeline: caosdb-cppinttest

#12637

    Pipeline passed for 498863ea on f-int32

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 3 years ago (Aug 26, 2021 12:40pm UTC)

    Merge details

    • Changes merged into with 3e95cd2e.
    • Deleted the source branch.

    Pipeline #12646 passed

    Pipeline: caosdb-cppinttest

    #12648

      Pipeline passed for 3e95cd2e on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      Please register or sign in to reply
      Loading