FIX: Transaction::GetResultSet() now always returns a good reference
Summary
See title. For #11 (closed).
Focus
Is the unique_ptr handling correct?
Test Environment
Just run the unit tests. They failed before the fix.
Check List for the Author
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Henrik tom Wörden
Merge request reports
Activity
mentioned in issue #11 (closed)
added 3 commits
-
d548acab...13b955a1 - 2 commits from branch
dev
- 381bd88a - Merge branch 'dev' into fix-11
-
d548acab...13b955a1 - 2 commits from branch
mentioned in commit 912a4290
Please register or sign in to reply