Skip to content
Snippets Groups Projects

FIX: Transaction::GetResultSet() now always returns a good reference

Merged Daniel Hornung requested to merge fix-11 into dev

Summary

See title. For #11 (closed).

Focus

Is the unique_ptr handling correct?

Test Environment

Just run the unit tests. They failed before the fix.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Pipeline #12586 passed with warnings

Pipeline: caosdb-cppinttest

#12587

    Pipeline passed with warnings for 381bd88a on fix-11

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 3 years ago (Aug 26, 2021 10:41am UTC)

    Merge details

    • Changes merged into with 912a4290.
    • Deleted the source branch.

    Pipeline #12624 passed with warnings

    Pipeline: caosdb-cppinttest

    #12625

      Pipeline passed with warnings for 912a4290 on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      Please register or sign in to reply
      Loading