Skip to content
Snippets Groups Projects

Workaround to return non-string values, according to the specified DataType.

Merged Workaround to return non-string values, according to the specified DataType.
f-parse-string-values into dev
2 unresolved threads
Merged Daniel Hornung requested to merge f-parse-string-values into dev
2 unresolved threads

Summary

Workaround to return non-string values, according to the specified DataType.

Focus

The code has many if-then instructions, which makes it complicated to read. The most important question is: Have I gotten them all correctly?

Test Environment

  • ./bin/cxxcaosdbcli -> should return a valid Double for the price.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
include/caosdb/entity.h
454 454 public:
455 455 explicit inline Property(ProtoProperty *other)
456 456 : value(Value(other->mutable_value())), data_type(DataType(other->mutable_data_type())),
457 wrapped(other){};
457 wrapped(other){
458 FixValue();
  • Daniel Hornung
    Daniel Hornung @daniel started a thread on an old version of the diff
    • src/caosdb/entity.cpp
    42 44
    43 45 Messages::~Messages() = default;
    44 46
    47 // Forward declarations ///////////////////////////////////////////////////////
    48
    49 template<typename E>
    50 auto FixValueImpl(E* ent) -> void;
  • Daniel Hornung changed title from Merge branch 'dev' into f-parse-string-values to Workaround to return non-string values, according to the specified DataType.

    changed title from Merge branch 'dev' into f-parse-string-values to Workaround to return non-string values, according to the specified DataType.

  • Daniel Hornung added 20 commits

    added 20 commits

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden mentioned in commit e47cf7f9

    mentioned in commit e47cf7f9

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply