Skip to content
Snippets Groups Projects

ENH: Allow insert/update/delete and files in Extern C

All threads resolved!

Summary

See https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/412

Focus

Point the reviewer to the core of the code change. Where should they start
reading? What should they focus on (e.g. security, performance,
maintainability, user-friendliness, compliance with the specs, finding more
corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen deleted the f-consolidate-c branch. This merge request now targets the dev branch

    deleted the f-consolidate-c branch. This merge request now targets the dev branch

  • added 4 commits

    Compare with previous version

  • added 2 commits

    • 897da977 - MAINT: rename Transaction::RetrieveAndDownloadFilesById
    • ebe07acd - ENH: add file download

    Compare with previous version

  • Henrik tom Wörden marked this merge request as ready

    marked this merge request as ready

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Henrik tom Wörden
  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung added 2 commits

    added 2 commits

    • 79af0a93 - ENH: Multi-threaded building in CI pipeline.
    • 14731539 - STY: Style changes and docstrings.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c78f699f - STY: Style and formatting changes.

    Compare with previous version

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • added 1 commit

    Compare with previous version

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung added 8 commits

    added 8 commits

    Compare with previous version

  • Daniel Hornung enabled an automatic merge when the pipeline for 62c0ced5 succeeds

    enabled an automatic merge when the pipeline for 62c0ced5 succeeds

  • Daniel Hornung canceled the automatic merge

    canceled the automatic merge

  • Daniel Hornung mentioned in commit 8467e61b

    mentioned in commit 8467e61b

  • Please register or sign in to reply
    Loading