F files
Summary
Insert a meaningful description for this merge request here. What is the
new/changed behavior? Which bug has been fixed? Are there related Issues?
Focus
Point the reviewer to the core of the code change. Where should they start
reading? What should they focus on (e.g. security, performance,
maintainability, user-friendliness, compliance with the specs, finding more
corner cases, concrete questions)?
Test Environment
How to set up a test environment for manual testing?
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Henrik tom Wörden
Merge request reports
Activity
marked this merge request as draft from 30f8bd23
added 9 commits
- 8572b83b - WIP: files
- 8adcd9c3 - WIP: files
- 23f4ad6d - WIP: files
- 59587e7e - WIP: files
- c9eb459b - WIP: files
- b2d5f3a7 - WIP: files
- 577bdea6 - Add license headers to new files
- ea446318 - Add license header to test/test_file_transmission.cpp
- 8eaa4281 - Merge branch 'f-files' of gitlab.indiscale.com:caosdb/src/caosdb-cpplib into f-files
Toggle commit listadded 4 commits
-
8eaa4281...e58611aa - 3 commits from branch
dev
- 52573ef4 - Merge branch 'dev' into f-files
-
8eaa4281...e58611aa - 3 commits from branch
added 3 commits
mentioned in issue #9 (closed)
enabled an automatic merge when the pipeline for d8bd8fce succeeds
mentioned in commit de91228b
Please register or sign in to reply