Skip to content

Verify that no-op tls implementations are not used

Summary

In the past,

Grpc was built with no-op tls implementations (which would not validate the tls certificates). I didn't find a convenient way to tell the linker to link against the secure ones, so I removed the unsecure ones instead.

string(REGEX REPLACE "grpc\\+?\\+?_unsecure" "" CONAN_LIBS_GRPC
    "${CONAN_LIBS_GRPC}")
string(REGEX REPLACE "grpc\\+?\\+?_unsecure" "" CONAN_PKG_LIBS_GRPC
    "${CONAN_PKG_LIBS_GRPC}")
string(REGEX REPLACE "grpc\\+?\\+?_unsecure" "" CONAN_LIBS
    "${CONAN_LIBS}")
string(REGEX REPLACE "grpc\\+?\\+?_unsecure" "" CONAN_PKG_LIBS
    "${CONAN_PKG_LIBS}")

(!49 (comment 77839))

We should take a closer look. I mean, there are integration tests which test this a bit. Maybe that is sufficient and we can remove this without replacement if the pass.

Specifications

  • Version: 0.3-dev with Conan 2
  • Platform: any

Possible fixes

If no-op tls implementations are used by gRPC, find a way to prevent that, e.g. by using build options in the conanfile.