Skip to content
Snippets Groups Projects
Verified Commit e4fc823b authored by Timm Fitschen's avatar Timm Fitschen
Browse files

Add TODO for SegFault Factory in GetResultSet

parent e6e57719
No related branches found
No related tags found
2 merge requests!42Release 0.2.0,!28F async execute
Pipeline #24895 passed
Pipeline: caosdb-cppinttest

#24896

    ...@@ -408,6 +408,10 @@ public: ...@@ -408,6 +408,10 @@ public:
    CAOSDB_LOG_ERROR(logger_name) CAOSDB_LOG_ERROR(logger_name)
    << "GetResultSet was called before the transaction has terminated. This is a programming " << "GetResultSet was called before the transaction has terminated. This is a programming "
    "error of the code which uses the transaction."; "error of the code which uses the transaction.";
    // TODO(tf) This is a really bad SegFault factory. When the transaction
    // terminates and the result_set is being overriden, the unique_ptr
    // created here will be deleted and any client of the return ResultSet
    // will have a SegFault.
    } else if (this->GetStatus().GetCode() == StatusCode::SPOILED) { } else if (this->GetStatus().GetCode() == StatusCode::SPOILED) {
    CAOSDB_LOG_ERROR(logger_name) CAOSDB_LOG_ERROR(logger_name)
    << "GetResultSet was called on a \"spoiled\" transaction. That means " << "GetResultSet was called on a \"spoiled\" transaction. That means "
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment