Skip to content
Snippets Groups Projects

Rename cppinttest

Merged Rename cppinttest
f-94-rename-cpplib into dev
All threads resolved!
Merged Joscha Schmiedt requested to merge f-94-rename-cpplib into dev
All threads resolved!

Summary

Relates to issue #5 (closed)

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports

Pipeline #54982 passed

Stage: info
    Stage: setup
      Stage: build
        Stage: test

          Pipeline passed for 8f97bdab on f-94-rename-cpplib

          Merged by Florian SpreckelsenFlorian Spreckelsen 5 months ago (Sep 5, 2024 4:04pm UTC)

          Loading

          Pipeline #55728 failed

          Stage: info
            Stage: setup
              Stage: build
                Stage: test

                  Pipeline failed for 02130d65 on dev

                  Activity

                  Filter activity
                  • Approvals
                  • Assignees & reviewers
                  • Comments (from bots)
                  • Comments (from users)
                  • Commits & branches
                  • Edits
                  • Labels
                  • Lock status
                  • Mentions
                  • Merge request status
                  • Tracking
                • Florian Spreckelsen resolved all threads

                  resolved all threads

                • Florian Spreckelsen enabled an automatic merge when the pipeline for 8f97bdab succeeds

                  enabled an automatic merge when the pipeline for 8f97bdab succeeds

                • Florian Spreckelsen mentioned in commit 02130d65

                  mentioned in commit 02130d65

                • Florian Spreckelsen merged

                  merged

                  • Please register or sign in to reply