Adapt for Conan 2
Summary
Moving cpplib to Conan 2 required quite a lot of changes, mostly to conanfile.py
and CMakeLists.txt
. This is also reflected in some changes in the integration tests.
Focus
...
Test Environment
Regular
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
assigned to @joschaschmiedt
added 1 commit
- be891fd2 - CHG: Add conan profile detection to Dockerfile
added 1 commit
- 2be4e662 - PIPELINE: Fix conan installation (use make conan)
added 1 commit
- ca7b280f - FIX: Makefile for CMake<3.23 (does not support presets)
mentioned in merge request caosdb-cpplib!49 (merged)
assigned to @florian
mentioned in commit 2fdfea98
Please register or sign in to reply