Skip to content

Fix pipeline for f-branches

Daniel Hornung requested to merge f-fix-f-branch-pipeline into dev

Summary

Added job build-testenv for all pipelines again. Before, it was called for everything except manual commits anyway, so this should not increase the server load.

Focus

  • Did I miss an occasion where running the job might cause problems or use too many ressources?

Test Environment

Just look at the pipeline. If this f branch runs through, it works as intended.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues #3 (closed)
  • Up-to-date CHANGELOG.md (or not necessary) -> No user changes.
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports