Skip to content
Snippets Groups Projects

F remove boost rdep

Merged F remove boost rdep
f-remove-boost-rdep into dev
1 unresolved thread
Merged Timm Fitschen requested to merge f-remove-boost-rdep into dev
1 unresolved thread

Summary

  1. Shows that segfault-bug fixed in caosdb-cpplib!39 (merged) (and that cpplib with boost as a build dependency runs fine)
  2. Shows that the bug from caosdb-server!53 (merged) is fixed
  3. Shows that https://gitlab.indiscale.com/caosdb/customers/cfaed/management/-/issues/40 is fixed

Test Environment

No manual testing needed. Pipelines should be enough

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen
    Timm Fitschen @timm started a thread on the diff
    • test/test_transaction.cpp
    745 763 test_numeric_values_impl<bool, bool>(AtomicDataType::BOOLEAN);
    746 764 }
    747 765
    766 /**
    767 * Test date time values.
    768 */
    769 TEST_F(test_transaction, test_datetime_values) {
  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen changed the description

    changed the description

  • Florian Spreckelsen
  • Timm Fitschen added 1 commit

    added 1 commit

    • 3c8d7551 - REVIEW: apply reviewers suggestions

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • Florian Spreckelsen mentioned in commit 5be5a6d2

    mentioned in commit 5be5a6d2

  • Florian Spreckelsen merged

    merged

    • Please register or sign in to reply