TST: resolve pending TODOs

test/test_transaction.cpp

@@ -825,7 +825,16 @@ TEST_F(test_transaction, test_multi_insert_transactions) {
   ASSERT_TRUE(insert_status.IsTerminated());
   ASSERT_FALSE(insert_status.IsError());
 
-  // TODO(tf) test end results
+  // test end results
+  auto retrieve_transaction(connection->CreateTransaction());
+  for (const Entity &entity : insert_transaction->GetResultSet()) {
+    retrieve_transaction->RetrieveById(entity.GetId());
+  }
+  retrieve_transaction->Execute();
+
+  auto retrieve_status = retrieve_transaction->GetStatus();
+  ASSERT_TRUE(retrieve_status.IsTerminated());
+  ASSERT_FALSE(retrieve_status.IsError());
 }
 
 /*
@@ -853,6 +862,7 @@ TEST_F(test_transaction, test_multi_update_transactions) {
 
   auto update_transaction(connection->CreateTransaction());
   for (Entity entity : retrieve_transaction->GetResultSet()) {
+    ASSERT_EQ(entity.GetDescription(), "");
     entity.SetDescription("NewDescription");
     ASSERT_EQ(update_transaction->UpdateEntity(&entity), StatusCode::GO_ON);
   }
@@ -863,7 +873,20 @@ TEST_F(test_transaction, test_multi_update_transactions) {
   ASSERT_TRUE(update_status.IsTerminated());
   ASSERT_FALSE(update_status.IsError());
 
-  // TODO(tf) test end results
+  // test end results
+  auto final_retrieve_transaction(connection->CreateTransaction());
+  for (const Entity &entity : update_transaction->GetResultSet()) {
+    final_retrieve_transaction->RetrieveById(entity.GetId());
+  }
+  final_retrieve_transaction->Execute();
+
+  auto final_retrieve_status = final_retrieve_transaction->GetStatus();
+  ASSERT_TRUE(final_retrieve_status.IsTerminated());
+  ASSERT_FALSE(final_retrieve_status.IsError());
+
+  for (const Entity &entity : final_retrieve_transaction->GetResultSet()) {
+    ASSERT_EQ(entity.GetDescription(), "NewDescription");
+  }
 }
 
 /*
@@ -928,7 +951,7 @@ TEST_F(test_transaction, test_multi_write_transactions) {
   EXPECT_TRUE(complex_transaction->GetStatus().IsTerminated());
   EXPECT_FALSE(complex_transaction->GetStatus().IsError());
 
-  // TODO(tf) test end results
+  // test end results
   retrieve_transaction = connection->CreateTransaction();
   ASSERT_EQ(retrieve_transaction->RetrieveById(entity_a_update.GetId()),
             StatusCode::GO_ON);
@@ -1289,7 +1312,8 @@ TEST_F(test_transaction, test_delete_string_id) {
   EXPECT_FALSE(results.at(0).HasErrors());
   EXPECT_TRUE(results.at(1).HasErrors());
   EXPECT_EQ(results.at(1).GetErrors().size(), 1);
-  EXPECT_EQ(results.at(1).GetErrors().at(0).GetDescription(), "Entity does not exist.");
+  EXPECT_EQ(results.at(1).GetErrors().at(0).GetDescription(),
+            "Entity does not exist.");
   EXPECT_FALSE(results.at(2).HasErrors());
 }