FIX: `to_table` failed on lists

Summary

Fix for #117 (closed)

Focus

• Performance
• Sufficient test

Test Environment

Run the unit test:

pytest --pdb --pdbcls=IPython.terminal.debugger:TerminalPdb unittests/test_table_converter.py::TableTest::test_list

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/table_converter.py

@@ -49,19 +49,15 @@ def generate_property_name(prop):
 
 
 def to_table(container):
-    """ creates a table from the records in a container """
+    """Create a table from the records in a container."""
 
     if len(container) == 0:
         raise ValueError("Container is empty")
-    properties = set()
-
-    for rec in container:
-        properties.update([generate_property_name(p)
-                           for p in container[0].get_properties()])
-    df = pd.DataFrame(columns=list(properties))
+        # TODO Why not this? return pd.DataFrame()
     rts = {p.name for p in container[0].parents}
 
-    for ii, rec in enumerate(container):
+    data = []
+    for rec in container:
         if {p.name for p in rec.parents} != rts:
             raise ValueError("Parents differ")
 
@@ -69,17 +65,10 @@ def to_table(container):
         for prop in rec.get_properties():
             propname = generate_property_name(prop)
             row_dict[propname] = prop.value
-            # if propname == "p5":
-            #     breakpoint()
-            # if isinstance(prop.value, list):
-            #     if propname not in df:
-            #         df[propname] = pd.Series(dtype=object)
-            #     elif df[propname].dtype != object:
-            #         df[propname] = df[propname].astype(object)
-            # df.at[ii, propname] = prop.value
-        df.loc[ii] = row_dict
-
-    return df
+        data.append(row_dict)
+    result = pd.DataFrame(data=data)
+
+    return result
 
 
 def from_table(spreadsheet, recordtype):