Filling XLSX: Everything except multiple choice.
-
Review changes -
-
Download -
Patches
-
Plain diff
All threads resolved!
All threads resolved!
Summary
For caosdb/customers/dimr/management#219:
Filling XLSX templates from JSON works now.
Focus
- Correct handling of foreign keys
- Correct handling of other lists
Test Environment
Run the unit tests.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Daniel Hornung
Merge request reports
Compare and
Show latest version
- version 26600c8c94
- version 2573bb9ca4
- version 24696acab9
- version 23d5420c8b
- version 2233c534be
- version 2133c534be
- version 20c6c305c5
- version 1941b61e37
- version 18ef33786a
- version 17c4e8b63d
- version 16b18c5df8
- version 15973f9928
- version 14fb6f182b
- version 134ef559b2
- version 12a504c310
- version 11db54ff43
- version 103931c9bd
- version 9eea46658
- version 831a2f79c
- version 72bdd7286
- version 63c5c5a1c
- version 5d9fed9b2
- version 42423efd7
- version 3c0b27ba5
- version 2299922bf
- version 1299922bf
- dev (base)
- latest versiond636c45c78 commits,
- version 26600c8c9478 commits,
- version 2573bb9ca477 commits,
- version 24696acab976 commits,
- version 23d5420c8b75 commits,
- version 2233c534be74 commits,
- version 2133c534be31 commits,
- version 20c6c305c530 commits,
- version 1941b61e3729 commits,
- version 18ef33786a28 commits,
- version 17c4e8b63d27 commits,
- version 16b18c5df826 commits,
- version 15973f992825 commits,
- version 14fb6f182b24 commits,
- version 134ef559b223 commits,
- version 12a504c31022 commits,
- version 11db54ff4321 commits,
- version 103931c9bd20 commits,
- version 9eea4665819 commits,
- version 831a2f79c18 commits,
- version 72bdd728617 commits,
- version 63c5c5a1c16 commits,
- version 5d9fed9b215 commits,
- version 42423efd714 commits,
- version 3c0b27ba513 commits,
- version 2299922bf12 commits,
- version 1299922bf55 commits,
Compare changes
- Side-by-side
- Inline
Files
15Loading