Skip to content
Snippets Groups Projects

Filling XLSX: Everything except multiple choice.

Merged Daniel Hornung requested to merge f-json-table into dev

Summary

For caosdb/customers/dimr/management#219:

Filling XLSX templates from JSON works now.

Focus

  • Correct handling of foreign keys
  • Correct handling of other lists

Test Environment

Run the unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #49423 passed with warnings

Pipeline passed with warnings for d636c45c on f-json-table

Merged by Henrik tom WördenHenrik tom Wörden 11 months ago (Apr 4, 2024 8:41am UTC)

Merge details

  • Changes merged into with a6b49610.
  • Deleted the source branch.

Pipeline #49425 passed with warnings

Pipeline passed with warnings for a6b49610 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung changed target branch from dev to f-more-jsonschema-export

    changed target branch from dev to f-more-jsonschema-export

  • Daniel Hornung added 1 commit

    added 1 commit

    • c0b27ba5 - MAINT: Removed unnecessary function.

    Compare with previous version

  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung requested review from @henrik

    requested review from @henrik

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading